Update makeBins.R #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That is correct. The type of this object must have changed in some recent version. Are you getting errors because of this type check? The old is(bins, "GRangesList") is still functional in my version. |
|
Yes
I think that there is an issue when using the developer version of the tool with R 3.5 (and associated bioconducter version >3.7).
On 11 May 2019, at 08:46, ataudt <[email protected]<mailto:[email protected]>> wrote:
That is correct. The type of this object must have changed in some recent version. Are you getting errors because of this type check? The old is(bins, "GRangesList") is still functional in my version.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#6 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEBSRG5I63PMHZOTBGE55Y3PUZ2V7ANCNFSM4HLKQ67Q>.
|
|
Hi Maise, I would like to merge the pull request but before I want to make sure if you have also encountered errors in other functions? I use the "GRangesList" quite a lot, and so you should have seen errors also in other functions. Is that true? |
|
Yes - these errors occur in other functions.
…Sent from my iPhone
On 27 May 2019, at 09:57, ataudt <[email protected]<mailto:[email protected]>> wrote:
Hi Maise, I would like to merge the pull request but before I want to make sure if you have also encountered errors in other functions? I use the "GRangesList" quite a lot, and so you should have seen errors also in other functions. Is that true?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#6?email_source=notifications&email_token=AEBSRG7T734X7PBJTAU6KT3PXOO6TA5CNFSM4HLKQ672YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWJHE6Y#issuecomment-496136827>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEBSRGYRWQH23XJ2ZXYA7N3PXOO6TANCNFSM4HLKQ67Q>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have trying to use your development version - and I believe that the binned.list is a CompressedGrangesList rather than just a GRangesList.